feat: invalidate persisted cache #635
Conversation
| workspace.Get().ChangeWorkspaceFolders(bgCtx, params) | ||
| command.HandleFolders(bgCtx, srv, di.Notifier()) | ||
| changedFolders := workspace.Get().ChangeWorkspaceFolders(params) | ||
| command.HandleFolders(bgCtx, srv, di.Notifier(), di.ScanPersister()) |
There was a problem hiding this comment.
i moved the persister init logic to the folder handlers
This refactoring here was to make sure that the persister is initialized before a new f.ScanFolder is triggered for the new added folder
ShawkyZ
changed the title
ShawkyZ
changed the title
| for _, folder := range params.Event.Removed { | ||
| w.RemoveFolder(uri.PathFromUri(folder.Uri)) | ||
| } | ||
|
|
||
| var changedWorkspaceFolders []*Folder |
There was a problem hiding this comment.
this is to avoid triggering scan before initializing the persister.
Caller is responsible for calling the scan for the new added folders
| @@ -38,6 +39,10 @@ const ( | |||
| SchemaVersion = "v1" | |||
| ) | |||
|
|
|||
| var ( | |||
| ExpirationInSeconds = 12 * 60 * 60 | |||
There was a problem hiding this comment.
This is not a constant to be able to override it in tests
| @@ -73,7 +73,7 @@ func Test_TrustFoldersAndScan_shouldAddFoldersToTrustedFoldersAndTriggerScan(t * | |||
| }, time.Second, time.Millisecond, "scanner should be called after trust is granted") | |||
| } | |||
|
|
|||
| func Test_AddAndRemoveFoldersAndTriggerScan(t *testing.T) { | |||
| func Test_AddAndRemoveFoldersAndReturnFolderList(t *testing.T) { | |||
There was a problem hiding this comment.
Where do you test the extracted trigger scan path now?
There was a problem hiding this comment.
in server_test Test_workspaceDidChangeWorkspaceFolders_shouldProcessChanges it checks if folder.Scanned()
I think it should be enough, wdyt ?
Description
Checklist